Skip to content

fix: remove extra empty lines insertion in SymfonyServiceClassConstantFixer#7761

Merged
soyuka merged 1 commit intoapi-platform:4.2from
Maxcastel:fix-php-cs-fixer-extra-whitespace
Feb 16, 2026
Merged

fix: remove extra empty lines insertion in SymfonyServiceClassConstantFixer#7761
soyuka merged 1 commit intoapi-platform:4.2from
Maxcastel:fix-php-cs-fixer-extra-whitespace

Conversation

@Maxcastel
Copy link
Contributor

@Maxcastel Maxcastel commented Feb 14, 2026

Related to #7706

Description

When running PHP CS Fixer, extra empty lines are added when use statements are added by SymfonyServiceClassConstantFixer::insertImports().

How to reproduce

  1. git revert 26302584a973c326dc627bda98895095cdd5bc54 (or just modify a file manually)
  2. vendor/bin/php-cs-fixer fix
  3. get extra empty lines

Before

Capture d’écran 2026-02-15 015656

After

Capture d’écran 2026-02-15 015903

@Maxcastel Maxcastel changed the base branch from main to 4.2 February 14, 2026 20:58
@Maxcastel Maxcastel marked this pull request as ready for review February 15, 2026 00:59
@Maxcastel Maxcastel changed the title fix: remove extra whitespace insertion in SymfonyServiceClassConstantFixer fix: remove extra empty lines insertion in SymfonyServiceClassConstantFixer Feb 15, 2026
@Maxcastel Maxcastel force-pushed the fix-php-cs-fixer-extra-whitespace branch 2 times, most recently from 66e6784 to f883c61 Compare February 16, 2026 13:40
@soyuka soyuka merged commit e6c510e into api-platform:4.2 Feb 16, 2026
255 of 277 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants