fix(serializer): translate PropertyAccess type mismatches to NotNormalizableValueException#7967
Merged
Merged
Conversation
…lizableValueException | Q | A | ------------- | --- | Branch? | 4.3 | Tickets | symfony/symfony#64159 | License | MIT | Doc PR | ∅ AbstractItemNormalizer::setAttributeValue() now catches PropertyAccess\InvalidArgumentException and rethrows as NotNormalizableValueException, mirroring the contract ObjectNormalizer implements per symfony/symfony#64067. Without this, null on a non-nullable typed property bubbled up as HTTP 500 instead of a 4xx denormalization error.
soyuka
force-pushed
the
fix/null-on-non-nullable
branch
from
af10f1e to
e2467a8
Compare
…ibuteValue contract | Q | A | ------------- | --- | Branch? | 4.3 | Tickets | symfony/symfony#64067 | License | MIT | Doc PR | ∅ The COLLECT_DENORMALIZATION_ERRORS aggregation in AbstractObjectNormalizer was reworked in symfony/symfony#64067 (released in 6.4.37 / 7.4.9 / 8.0.9). Now that AbstractItemNormalizer implements that contract, older Symfony parents would no longer aggregate our translated exceptions and would respond with 400 instead of 422.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractItemNormalizer::setAttributeValue() now catches PropertyAccess\InvalidArgumentException and rethrows as NotNormalizableValueException, mirroring the contract ObjectNormalizer implements per symfony/symfony#64067. Without this, null on a non-nullable typed property bubbled up as HTTP 500 instead of a 4xx denormalization error.