fix(metadata): negotiate wildcard Accept with parameters#8192
Merged
Conversation
willdurand/negotiation treats media-range parameters as match constraints, so `*/*; charset=utf-8` (sent by default by some clients like PhpStorm) fails to match offered MIME types that do not carry the same parameter, returning 406 Not Acceptable. Retry with a bare `*/*` on failure when the Accept header contains a wildcard. Concrete media types are left untouched so vendor- specific negotiation (e.g. JSON:API `profile`) is preserved. Closes api-platform#1532
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
willdurand/negotiationtreats media-range parameters as match constraints, so*/*; charset=utf-8(sent by default by clients like PhpStorm) fails to match offered MIME types and returns406 Not Acceptable.*/*when the Accept header contains a wildcard. Concrete media types are left untouched so vendor-specific negotiation (e.g. JSON:APIprofile) is preserved.Test plan
*/*picks first configured format*/*; charset=utf-8picks first configured format (the Content-Type */* generates error when format restriction configured #1532 fix)*/*; charset=utf-8; q=0.1, text/html; q=0.9still pickstext/html(q-precedence preserved)application/xml) still returns406FormatTest,ErrorFormatTest,JsonLdTest,JsonApiTest,ContentNegotiationProviderTestall greenCloses #1532