fix(tests): symfony 8.1 compat#8210
Merged
Merged
Conversation
3422a20 to
53d4b47
Compare
53d4b47 to
45bc35a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores HttpCache / Hydra / JsonApi / Symfony Bundle PHPUnit jobs and PHPStan against Symfony 8.1.0:
ResponseHeaderBagandParameterBagbecamefinalin Symfony HttpFoundation 8.1.0.createMock()on a final class triggers a fatal in PHPUnit 12. Swap the mocks inAddTagsProcessorTest,HydraLinkProcessorTest,JsonApiProviderTestandMercureLinkProcessorTestfor real instances and assert on bag state after the call. Behaviour identical, assertions tightened (now verify the actual stored value instead ofexpects(...)->method('set')).Application::add(). The fallback branch inDebugResourceCommandTest::getCommandTester()is unreachable on Symfony ≥ 7.4 but must be kept for Symfony 6.4 support. Add a targetedphpstan.neon.distignore (reportUnmatched: false) so analysis passes on both Symfony 6.4 and 8.1.Test plan
vendor/bin/phpunit src/HttpCache/Tests src/Hydra/Tests src/JsonApi/Tests tests/Symfony/Bundle/Command/DebugResourceCommandTest.php tests/Symfony/State/MercureLinkProcessorTest.php— green locally on Symfony 7.4vendor/bin/phpstan analyse— no errorshttp-cache,hydra,json-api,state) and the PHPStan job