Skip to content

fix(doctrine): resolve parent link toProperty during PUT create #8233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soyuka merged 1 commit into from
Jun 3, 2026
+87 −3
Merged

fix(doctrine): resolve parent link toProperty during PUT create #8233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions src/Doctrine/Common/State/PersistProcessor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,16 +81,37 @@ public function process(mixed $data, Operation $operation, array $uriVariables =
// We create a new entity through PUT
} else {
foreach (array_reverse($links) as $link) {
if ($link->getExpandedValue() || !$link->getFromClass()) {
if ($link->getExpandedValue() || !($fromClass = $link->getFromClass())) {
continue;
}

$identifierProperties = $link->getIdentifiers();
$hasCompositeIdentifiers = 1 < \count($identifierProperties);
$toProperty = $link->getToProperty();
$parentManager = $toProperty ? $this->managerRegistry->getManagerForClass($fromClass) : null;

if ($toProperty && $parentManager && isset($reflectionProperties[$toProperty]) && method_exists($parentManager, 'getReference')) {
if ($hasCompositeIdentifiers) {
$referenceIdentifier = [];
foreach ($identifierProperties as $identifierProperty) {
$referenceIdentifier[$identifierProperty] = $this->getIdentifierValue($identifiers, $identifierProperty);
}
} else {
$referenceIdentifier = $this->getIdentifierValue($identifiers);
}

$reflectionProperties[$toProperty]->setValue($newData, $parentManager->getReference($fromClass, $referenceIdentifier));

continue;
}

foreach ($identifierProperties as $identifierProperty) {
$reflectionProperty = $reflectionProperties[$identifierProperty];
$reflectionProperty->setValue($newData, $this->getIdentifierValue($identifiers, $hasCompositeIdentifiers ? $identifierProperty : null));
if (!isset($reflectionProperties[$identifierProperty])) {
$this->getIdentifierValue($identifiers, $hasCompositeIdentifiers ? $identifierProperty : null);
continue;
}

$reflectionProperties[$identifierProperty]->setValue($newData, $this->getIdentifierValue($identifiers, $hasCompositeIdentifiers ? $identifierProperty : null));
}
}

Expand Down
63 changes: 63 additions & 0 deletions src/Doctrine/Common/Tests/State/PersistProcessorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,12 @@
use ApiPlatform\Doctrine\Common\Tests\Fixtures\TestBundle\Entity\Dummy;
use ApiPlatform\Doctrine\Common\Tests\Fixtures\TestBundle\Entity\DummyWithUninitializedProperties;
use ApiPlatform\Metadata\Get;
use ApiPlatform\Metadata\Link;
use ApiPlatform\Metadata\Post;
use ApiPlatform\Metadata\Put;
use ApiPlatform\State\ProcessorInterface;
use Doctrine\ODM\MongoDB\Mapping\ClassMetadata;
use Doctrine\ORM\EntityManagerInterface;
use Doctrine\ORM\Mapping\ClassMetadata as ORMClassMetadata;
use Doctrine\Persistence\ManagerRegistry;
use Doctrine\Persistence\ObjectManager;
Expand Down Expand Up @@ -141,4 +144,64 @@ public function testHandleLazyObjectRelationsSkipsUninitializedProperties(): voi
$result = (new PersistProcessor($managerRegistryProphecy->reveal()))->process($dummy, new Post(map: true));
$this->assertSame($dummy, $result);
}

public function testPersistPutCreateResolvesParentLinkViaToProperty(): void
{
$device = new PersistProcessorTestDeviceStub();

$userReference = new PersistProcessorTestUserStub();
$userReference->id = 'user-uuid';

$deviceClassMetadata = new ORMClassMetadata(PersistProcessorTestDeviceStub::class);
$deviceClassMetadata->identifier = ['id'];

$deviceManagerProphecy = $this->prophesize(EntityManagerInterface::class);
$deviceManagerProphecy->getClassMetadata(PersistProcessorTestDeviceStub::class)->willReturn($deviceClassMetadata);
$deviceManagerProphecy->contains($device)->willReturn(false);
$deviceManagerProphecy->persist($device)->shouldBeCalled();
$deviceManagerProphecy->flush()->shouldBeCalled();
$deviceManagerProphecy->refresh($device)->shouldBeCalled();

$userManagerProphecy = $this->prophesize(EntityManagerInterface::class);
$userManagerProphecy->getReference(PersistProcessorTestUserStub::class, 'user-uuid')
->willReturn($userReference)
->shouldBeCalledTimes(1);
$userManagerProphecy->contains($userReference)->willReturn(true);

$managerRegistryProphecy = $this->prophesize(ManagerRegistry::class);
$managerRegistryProphecy->getManagerForClass(PersistProcessorTestDeviceStub::class)->willReturn($deviceManagerProphecy->reveal());
$managerRegistryProphecy->getManagerForClass(PersistProcessorTestUserStub::class)->willReturn($userManagerProphecy->reveal());

$operation = new Put(
extraProperties: ['standard_put' => true],
uriVariables: [
'userId' => new Link(toProperty: 'user', fromClass: PersistProcessorTestUserStub::class, identifiers: ['id']),
'id' => new Link(fromClass: PersistProcessorTestDeviceStub::class, identifiers: ['id']),
],
);

$result = (new PersistProcessor($managerRegistryProphecy->reveal()))->process(
$device,
$operation,
['userId' => 'user-uuid', 'id' => 'device-uuid'],
['previous_data' => null],
);

$this->assertSame($device, $result);
$this->assertSame($userReference, $device->user);
$this->assertSame('device-uuid', $device->id);
}
}

/** @internal */
class PersistProcessorTestUserStub
{
public ?string $id = null;
}

/** @internal */
class PersistProcessorTestDeviceStub
{
public ?string $id = null;
public ?PersistProcessorTestUserStub $user = null;
}
Loading