fix(doctrine): extract alias from sql function in orderby parts#8240
Merged
soyuka merged 1 commit intoJun 4, 2026
Merged
Conversation
QueryChecker::hasOrderByOnFetchJoinedToManyAssociation exploded each orderBy part on "." to derive an alias. For SQL function calls such as "find_in_set(t.type, 'INTERVIEW')", the first segment was "find_in_set(t", which QueryBuilderHelper::traverseJoins then rejected with LogicException: The alias "find_in_set(t" does not exist. Strip any leading SQL function prefix before treating the segment as an alias. Fixes api-platform#8083
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QueryChecker::hasOrderByOnFetchJoinedToManyAssociation()derives an alias by splitting each orderBy part on.. When the orderBy is a SQL function call such asfind_in_set(t.type, 'INTERVIEW'), the split yields['find_in_set(t', "type, 'INTERVIEW')"]— the first segment is then passed toQueryBuilderHelper::traverseJoins(), which throws:Fix: strip the leading SQL function prefix (everything up to and including
() before treating the segment as an alias. Applies the patch the reporter validated locally.Fixes #8083
Test plan
testHasOrderByOnFetchJoinedToManyAssociationWithSqlFunctionInOrderByreproduces the crash without the fix and passes with it.QueryCheckerTestcases remain green (15/15).