Skip to content

chore(file-upload): modernize to an existing resource part #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2024
Merged

chore(file-upload): modernize to an existing resource part #2059

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions core/file-upload.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,9 +349,7 @@ use Symfony\Component\HttpFoundation\File\File;
use Symfony\Component\Serializer\Annotation\Groups;
use Vich\UploaderBundle\Mapping\Annotation as Vich;

/**
* @Vich\Uploadable
*/
#[Vich\Uploadable]
#[ORM\Entity]
#[ApiResource(
normalizationContext: ['groups' => ['book:read']],
Expand All @@ -373,9 +371,10 @@ class Book
#[Groups(['book:read'])]
public ?string $contentUrl = null;

/**
* @Vich\UploadableField(mapping="media_object", fileNameProperty="filePath")
*/
#[Vich\UploadableField(
mapping: 'media_object',
fileNameProperty: 'filePath',
)]
#[Groups(['book:write'])]
public ?File $file = null;

Expand Down Expand Up @@ -404,7 +403,7 @@ final class MultipartDecoder implements DecoderInterface
{
public const FORMAT = 'multipart';

public function __construct(private RequestStack $requestStack)
public function __construct(private readonly RequestStack $requestStack)
{
}

Expand Down Expand Up @@ -459,8 +458,6 @@ final class UploadedFileDenormalizer implements DenormalizerInterface
public function getSupportedTypes(?string $format): array
{
return [
'object' => null,
'*' => false,
File::class => true,
];
}
Expand Down