Skip to content

Do not use stylized form of "NGINX" #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Do not use stylized form of "NGINX" #911

wants to merge 1 commit into from

Conversation

@teohhanhui
Copy link
Contributor

@teohhanhui teohhanhui commented Oct 4, 2019 •
edited
Loading

Problem introduced in #903

See #903 (review)

Note: The "official form" is "nginx": https://nginx.org/en/

@teohhanhui teohhanhui requested a review from dunglas October 4, 2019 13:01
@alanpoulain
Copy link
Member

alanpoulain commented Oct 4, 2019

It's not really clear.

@teohhanhui
Copy link
Contributor Author

teohhanhui commented Oct 4, 2019

If it can be written as both nginx and NGINX, then I think we should prefer nginx as it's more friendly (doesn't feel like shouting) and easier to type.

@soyuka
Copy link
Member

soyuka commented Oct 4, 2019

It's not really clear.

He just wants a t-shirt so badly.

/s

@teohhanhui teohhanhui closed this Feb 24, 2020
@teohhanhui teohhanhui deleted the fix/stylized-nginx branch February 24, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dunglas dunglas Awaiting requested review from dunglas

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@teohhanhui @alanpoulain @soyuka