docs: update tdd-workflow/SKILL.md error-testing patterns#12
Merged
jonthegeek merged 4 commits intomainfrom Mar 20, 2026
Merged
docs: update tdd-workflow/SKILL.md error-testing patterns#12jonthegeek merged 4 commits intomainfrom
jonthegeek merged 4 commits intomainfrom
Conversation
Co-authored-by: jonthegeek <33983824+jonthegeek@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update tdd-workflow skill documentation
docs: update tdd-workflow/SKILL.md error-testing patterns
Mar 20, 2026
jonthegeek
reviewed
Mar 20, 2026
jonthegeek
approved these changes
Mar 20, 2026
Contributor
jonthegeek
left a comment
There was a problem hiding this comment.
Looks great as long as we didn't somehow break checks!
Copilot AI
added a commit
that referenced
this pull request
Mar 20, 2026
Co-authored-by: jonthegeek <33983824+jonthegeek@users.noreply.github.com> Agent-Logs-Url: https://github.com/api2r/pkgskills/sessions/789f1d81-1bb1-49a2-8b81-0f1da15927d0
Copilot AI
added a commit
that referenced
this pull request
Mar 20, 2026
Co-authored-by: jonthegeek <33983824+jonthegeek@users.noreply.github.com> Agent-Logs-Url: https://github.com/api2r/pkgskills/sessions/1878843d-e61b-40e9-8765-29da53362ba4
Copilot AI
added a commit
that referenced
this pull request
Mar 20, 2026
Installs the github skill (gh CLI + commit message guidance) into a project with a single function call. Delegates to .use_skill() following the same pattern as use_skill_document(). - Closes #12 Co-authored-by: jonthegeek <33983824+jonthegeek@users.noreply.github.com> Agent-Logs-Url: https://github.com/api2r/pkgskills/sessions/6197315a-9a07-4197-8bb8-e3f0847d980a
Copilot AI
added a commit
that referenced
this pull request
Mar 22, 2026
…is called (#12) Co-authored-by: jonthegeek <33983824+jonthegeek@users.noreply.github.com> Agent-Logs-Url: https://github.com/api2r/pkgskills/sessions/dab485c2-910b-4aa0-9d96-4b48bb125778
Copilot AI
added a commit
that referenced
this pull request
Mar 22, 2026
…epr dep (#12) Co-authored-by: jonthegeek <33983824+jonthegeek@users.noreply.github.com> Agent-Logs-Url: https://github.com/api2r/pkgskills/sessions/c2f4a840-8e65-4103-bc83-83565ac39714
Copilot AI
added a commit
that referenced
this pull request
Mar 22, 2026
Co-authored-by: jonthegeek <33983824+jonthegeek@users.noreply.github.com> Agent-Logs-Url: https://github.com/api2r/pkgskills/sessions/a090f86d-a474-436a-9365-6ae42e7c7ec9
jonthegeek
added a commit
that referenced
this pull request
Mar 22, 2026
* Initial plan * feat: add use_skill_search_code() (#12) Co-authored-by: jonthegeek <33983824+jonthegeek@users.noreply.github.com> Agent-Logs-Url: https://github.com/api2r/pkgskills/sessions/1878843d-e61b-40e9-8765-29da53362ba4 * feat: add astgrepr to Suggests via desc when use_skill_search_code() is called (#12) Co-authored-by: jonthegeek <33983824+jonthegeek@users.noreply.github.com> Agent-Logs-Url: https://github.com/api2r/pkgskills/sessions/dab485c2-910b-4aa0-9d96-4b48bb125778 * feat: use rlang::check_installed() + usethis::use_package() for astgrepr dep (#12) Co-authored-by: jonthegeek <33983824+jonthegeek@users.noreply.github.com> Agent-Logs-Url: https://github.com/api2r/pkgskills/sessions/c2f4a840-8e65-4103-bc83-83565ac39714 * fix: replace #12 with #20 in tests and NEWS Co-authored-by: jonthegeek <33983824+jonthegeek@users.noreply.github.com> Agent-Logs-Url: https://github.com/api2r/pkgskills/sessions/a090f86d-a474-436a-9365-6ae42e7c7ec9 * refactor: simplify astgrepr dep check; use desc_get_deps in tests Co-authored-by: jonthegeek <33983824+jonthegeek@users.noreply.github.com> Agent-Logs-Url: https://github.com/api2r/pkgskills/sessions/1a0474a2-248f-453f-96b7-7a23d1f9fe15 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jonthegeek <33983824+jonthegeek@users.noreply.github.com>
jonthegeek
added a commit
that referenced
this pull request
Mar 22, 2026
* Initial plan * feat: add use_skill_github() Installs the github skill (gh CLI + commit message guidance) into a project with a single function call. Delegates to .use_skill() following the same pattern as use_skill_document(). - Closes #12 Co-authored-by: jonthegeek <33983824+jonthegeek@users.noreply.github.com> Agent-Logs-Url: https://github.com/api2r/pkgskills/sessions/6197315a-9a07-4197-8bb8-e3f0847d980a * Apply suggestions from code review Co-authored-by: Jon Harmon <jonthegeek@gmail.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jonthegeek <33983824+jonthegeek@users.noreply.github.com> Co-authored-by: Jon Harmon <jonthegeek@gmail.com>
jonthegeek
added a commit
that referenced
this pull request
Mar 22, 2026
* Initial plan * feat: add use_skill_implement_issue() (#12) Co-authored-by: jonthegeek <33983824+jonthegeek@users.noreply.github.com> Agent-Logs-Url: https://github.com/api2r/pkgskills/sessions/789f1d81-1bb1-49a2-8b81-0f1da15927d0 * air format Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jonthegeek <33983824+jonthegeek@users.noreply.github.com> Co-authored-by: Jon Harmon <jonthegeek@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
tdd-workflowskill documented bareexpect_error()calls and a stale standalone section that didn't reflect how this project actually tests errors. Updates.github/skills/tdd-workflow/SKILL.md:### Conditionsrewritten — three subsections by error source:stbl-style via.pkg_abort()) →expect_pkg_error_snapshot()stblvalidation errors →stbl::expect_pkg_error_classes()expect_error()/expect_snapshot()### Snapshot testscleaned up — removed theexpect_error()-inside-expect_snapshot()example and its cross-reference; section now covers only non-error snapshots## Testing errors with stbl::expect_pkg_error_classes()removed — fully absorbed into the updated Conditions sectionmypkg→pkgskills— replaced placeholder names inwithrandlocal_pkg()examplesOriginal prompt
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.