Remove the workaround for the (non-existent) TimelockManager bug#305
Merged
bbenligiray merged 1 commit intomainfrom Jul 7, 2021
Merged
Remove the workaround for the (non-existent) TimelockManager bug#305bbenligiray merged 1 commit intomainfrom
bbenligiray merged 1 commit intomainfrom
Conversation
Ashar2shahid
approved these changes
Jul 7, 2021
Contributor
Ashar2shahid
left a comment
Ashar2shahid
left a comment
There was a problem hiding this comment.
Everything looks good
bbenligiray
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation has a workaround that ensures that
releaseStart<releaseEnd, based on the concern that if we are pastreleaseEndwhenwithdrawToPool()is called, this line will cause the transferred timelock to have a largerreleaseStartthanreleaseEnd.This concern is invalid, as if
now>=releaseEnd, the entire timelock will be unlocked, resulting intimelockedbeing 0 and the offending line not being reached. In other words,TimelockManager.solhas no issue that needs to be worked around, so the related "fix" can be reverted. This shouldn't affect how things work in practice.