Skip to content

Remove verify-airnode-addresses.md #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bbenligiray merged 1 commit into from
Mar 14, 2025
Merged

Remove verify-airnode-addresses.md #173

bbenligiray merged 1 commit into from
Mar 14, 2025

Conversation

@bbenligiray
Copy link
Member

@bbenligiray bbenligiray commented Mar 14, 2025

Closes #172

@github-actions
Copy link

github-actions bot commented Mar 14, 2025

Visit the preview URL for this PR (updated for commit 46a8f46):

https://oev-docs--pr173-remove-verify-airnod-9oixexpv.web.app

(expires Fri, 21 Mar 2025 12:11:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6915b094b5ba83fde754632ba50c1ee9406d433f

@bbenligiray
Copy link
Member Author

bbenligiray commented Mar 14, 2025

CI failure is false positive

@bbenligiray bbenligiray merged commit e90b152 into main Mar 14, 2025
2 of 3 checks passed
@bbenligiray bbenligiray deleted the remove-verify-airnode-addresses branch March 14, 2025 12:13
Siegrift
Siegrift reviewed Mar 17, 2025
View reviewed changes
docs/dapps/verify-airnode-addresses.md

<PageHeader/>

# Verify Airnode addresses
Copy link
Collaborator

@Siegrift Siegrift Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're still linking to this page from the market in the source feed tooltip. This is also present in the new designs.

image

I think there should be some docs section explaining how the verification works, because the user doesn't understand what the external link means (e.g. this)

Copy link
Member Author

@bbenligiray bbenligiray Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, it should link https://docs.api3.org/dapps/integration/#verifying-first-party-sources
I was meaning to rewrite that tooltip anyway so let me go and do that now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siegrift Siegrift Siegrift left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove verify-airnode-addresses.md

3 participants

@bbenligiray @Siegrift