-
Notifications
You must be signed in to change notification settings - Fork 4
Update dApp docs according to the OEV Network changes #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| See the [`data-feed-proxy-combinators`](https://github.com/api3dao/data-feed-proxy-combinators) repository for various modular contracts that you can use to create combinations out of Api3ReaderProxyV1 contracts. | ||
| For example, you can combine an `ETH/USD` Api3ReaderProxyV1 contract and a `wstETH/ETH Exchange Rate` Api3ReaderProxyV1 contract to read a `wstETH/USD` value. | ||
|
|
||
| ## Mixed oracle design |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figure this is not nearly as relevant now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still a widespread anti-pattern across our partnered dApps. I'd personally keep that (even if in some shorter form).
|
Visit the preview URL for this PR (updated for commit 4e09aba): https://oev-docs--pr260-dapps-oev-updates-2vj6nzha.web.app (expires Mon, 10 Nov 2025 11:54:31 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6915b094b5ba83fde754632ba50c1ee9406d433f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also agree with pruning the mentions of OEV Network from the dApps section. Apart from simplicity it also makes the whole dapps section accurate 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I like the simpler wording.
| See the [`data-feed-proxy-combinators`](https://github.com/api3dao/data-feed-proxy-combinators) repository for various modular contracts that you can use to create combinations out of Api3ReaderProxyV1 contracts. | ||
| For example, you can combine an `ETH/USD` Api3ReaderProxyV1 contract and a `wstETH/ETH Exchange Rate` Api3ReaderProxyV1 contract to read a `wstETH/USD` value. | ||
|
|
||
| ## Mixed oracle design |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still a widespread anti-pattern across our partnered dApps. I'd personally keep that (even if in some shorter form).
Related to #253