Merged
Conversation
This was referenced Nov 18, 2023
Siegrift
commented
Nov 18, 2023
andreogle
approved these changes
Nov 21, 2023
Siegrift
force-pushed
the
processing-v2
branch
from
71a5068 to
f4756c0
Compare
andreogle
approved these changes
Nov 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #27
Rationale
The change starts with introducing new processing option in OIS, called
preProcessingSpecificationV2andpostProcessingSpecificationV2respectively. Note, that original issue only talks about post processing, but since we are changing the format is makes sense to also do pre processing.The new processing code requires user to write a function which accepts the input as first argument and the output is a return value. This function can be both async or sync. See many examples in the tests. There are also tests which take the v1 snippets and convert them to v2.
The old implementation functions are suffixed with
V1version andpostProcessApiCallResponseandpreProcessApiCallParametersabstract away which processing is used (under the hood they choose either v1 or v2 implementation) and they return a standard response. This is especially nice for end use, such as Airnode or Pusher.