Conversation
Siegrift
left a comment
There was a problem hiding this comment.
👍 LGTM. Is there anything more needed?
Maybe having the type on the output payload dictionary is too verbose 🤷, happy to revert of course, but this way it will be obvious in future if there's a mismatch.
Not sure what this means.
haha, thanks, if you haven't noticed then it's not a problem 😆 |
|
I originally included the output type in the handler, but by doing so it caused the dist path to shift up 2-levels, so the path became |
Siegrift
left a comment
There was a problem hiding this comment.
I originally included the output type in the handler, but by doing so it caused the dist path to shift up 2-levels, so the path became dist/api/src/index.js instead of just dist/index.js. I reverted the change to prevent this from happening.
Yeah, they are separate projects (similarly to airnode packages) so to make that work we would need to have commons package which would export these interfaces for both which is too much work.
I think the interfaces should rarely change so this 👍 LGTM.
This PR updates the response schema and associated test resources.
Maybe having the type on the output payload dictionary is too verbose 🤷, happy to revert of course, but this way it will be obvious in future if there's a mismatch.Closes #115