Conversation
|
|
||
| // Intentionally making the message as constant so that it is not accidentally changed. API integrations team (and maybe | ||
| // other teams, such as monitoring) will listen for this exact message to parse the heartbeat. | ||
| const HEARTBEAT_LOG_MESSAGE = 'Sending heartbeat log.'; |
andreogle
left a comment
andreogle
left a comment
There was a problem hiding this comment.
Kinda puzzled by this one. What's the reason for the full stops everywhere?
Most log message (I think?) I've seen don't have a full stop at the end. It seems kinda unnecessary imo - we're not exactly writing long paragraphs in our log messages. That said, I don't have a big problem with it
I dislike the inconsistency between some messages having it and some don't. We could do with or without a dot and I chose to add it because sometimes you want to write two sentences and use a dot in the middle. E.g. |
|
I omit the period if I'm writing a single sentence and use it otherwise. It's more of a style thing though, I find single sentences ending with periods too sassy. |
|
Yeah, it's mostly matter of style and it's not a big deal if it's inconsistent, but I still consider it an improvement. I did a quick search and there are people recommending the same log style. |
|
Sorry, after I merged this PR I realized we might have not finished the discussion. Let me know if you strongly see it your way and I can revert. Otherwise, I'll keep it merged. |
3 participants
Closes #144