Automate release process, support NPM publishing#179
Merged
Conversation
442330f to
c8db06b
Compare
Siegrift
commented
Dec 21, 2023
andreogle
approved these changes
Dec 21, 2023
c8db06b to
dd007d5
Compare
a61b9a0 to
71d7a3d
Compare
dd007d5 to
9ff585d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #164
Closes #165
Closes #167
Rationale
We agreed on call to publish the packages with the same version (similarly to Airnode). I looked for potential solutions that do this, because such workspace versioning not natively supported by PNPM nor NPM. We can use changesets (what Airnode does) or do this ourselves. I did a small pros/cons:
Changesets
Custom Script
and ended up with implementing a version script.
Related
apiworkspace tosigned-apiso that the package is the same as on NPM.@api3/signed-apiand@api3/airnode-feed.