Skip to content

Add husky hooks, CI tests and purge dependencies#5

Merged
Siegrift merged 7 commits intomainfrom
setup-husky-ci
Sep 18, 2023
Merged

Add husky hooks, CI tests and purge dependencies#5
Siegrift merged 7 commits intomainfrom
setup-husky-ci

Conversation

@Siegrift
Copy link
Collaborator

@Siegrift Siegrift commented Sep 18, 2023

  • Setup Husky with pre-push hook - I've only added pre-push hook (because pre-commit is unusable if you do rebase) and I've only included prettier and eslint. Let me know if you prefer also tsc and tests.
  • Add GH actions lint/test
  • Make lint and tests pass
  • Purge and make consistent use of dependencies. Each workspace defines it's own dependencies, but I moved common dev dependencies to monorepo root. This makes it convenient because the the project doesn't need to install it and all projects will use the same version by default.

@Siegrift Siegrift self-assigned this Sep 18, 2023
@Siegrift Siegrift changed the title WIP: Add pre-push hook husky WIP: Add husky and CI tests Sep 18, 2023
@Siegrift Siegrift changed the title WIP: Add husky and CI tests Add husky and CI tests Sep 18, 2023
@Siegrift Siegrift changed the title Add husky and CI tests Add husky hooks, CI tests and purge dependencies Sep 18, 2023
@@ -0,0 +1 @@
../../.eslintignore No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these files needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Siegrift Siegrift mentioned this pull request Sep 18, 2023
4 tasks
@Siegrift Siegrift changed the base branch from pnpm-workspace-init to main September 18, 2023 14:32
@Siegrift Siegrift merged commit 0caa6a1 into main Sep 18, 2023
@bbenligiray bbenligiray deleted the setup-husky-ci branch September 20, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants