Skip to content

test: add consumer credential ginkgo e2e#27

Merged
guoqqqi merged 1 commit into
api7:mainfrom
guoqqqi:test/e2e-consumer-credential-ginkgo
Apr 28, 2026
Merged

test: add consumer credential ginkgo e2e#27
guoqqqi merged 1 commit into
api7:mainfrom
guoqqqi:test/e2e-consumer-credential-ginkgo

Conversation

@guoqqqi
Copy link
Copy Markdown
Contributor

@guoqqqi guoqqqi commented Apr 28, 2026

Summary

  • add Ginkgo E2E coverage for consumer create/list/export/get/update/delete flows
  • add Ginkgo E2E coverage for credential create/list/get/update/delete and validation flows
  • assert resource state with CLI reads against the real APISIX Admin API
  • keep existing mock Admin API unit tests untouched

Verification

Note: full local E2E currently depends on the array-nodes compatibility fix in #26 when the local APISIX contains routes whose upstream.nodes is returned as an array.

Copilot AI review requested due to automatic review settings April 28, 2026 03:23
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

Warning

Rate limit exceeded

@guoqqqi has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 51 minutes and 29 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4e77ea82-f49b-4edb-bd5e-bf31ca45b06d

📥 Commits

Reviewing files that changed from the base of the PR and between 0792850 and 08317c4.

📒 Files selected for processing (1)
  • test/e2e/consumer_credential_ginkgo_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds new Ginkgo-based E2E coverage for the consumer and credential CLI commands, validating CRUD behavior and key validation paths against a real APISIX Admin API while keeping existing mock/unit tests unchanged.

Changes:

  • Added Ordered Ginkgo E2E specs for consumer create/list/export/get/update/delete flows (including required-flag and not-found behavior).
  • Added Ordered Ginkgo E2E specs for credential create/list/get/update/delete flows plus validation coverage (missing flags / missing credential id).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants