Skip to content

test: enable skywalking plugin in e2e apisix#32

Merged
guoqqqi merged 1 commit intoapi7:mainfrom
guoqqqi:test/enable-skywalking-plugin
Apr 28, 2026
Merged

test: enable skywalking plugin in e2e apisix#32
guoqqqi merged 1 commit intoapi7:mainfrom
guoqqqi:test/enable-skywalking-plugin

Conversation

@guoqqqi
Copy link
Copy Markdown
Contributor

@guoqqqi guoqqqi commented Apr 28, 2026

Summary

  • enable the APISIX skywalking plugin in the CI and docker-compose E2E APISIX configs
  • keep the default APISIX HTTP plugin list intact so existing E2E coverage keeps working
  • allow the existing skywalking skill test to validate CLI/Admin API configuration instead of skipping when the plugin is disabled

Verification

  • docker run --rm -v /Users/huahua/workspace/a6/test/e2e/apisix_conf/config.yaml:/usr/local/apisix/conf/config.yaml:ro apache/apisix:3.15.0-debian apisix test
  • docker run --rm -v /Users/huahua/workspace/a6/test/e2e/apisix_conf/config-docker.yaml:/usr/local/apisix/conf/config.yaml:ro apache/apisix:3.15.0-debian apisix test
  • APISIX_ADMIN_URL=http://127.0.0.1:19180 APISIX_GATEWAY_URL=http://127.0.0.1:19080 APISIX_CONTROL_URL=http://127.0.0.1:19090 HTTPBIN_URL=http://127.0.0.1:18080 APISIX_ADMIN_KEY=edd1c9f034335f136f87ad84b625c8f1 GOCACHE=/tmp/go-build-a6 go test -tags e2e ./test/e2e/skills -run TestSkillPluginSkywalking -v -count=1
  • GOCACHE=/tmp/go-build-a6 go test ./...

Copilot AI review requested due to automatic review settings April 28, 2026 09:21
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

Warning

Rate limit exceeded

@guoqqqi has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 22 minutes and 12 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d659b25d-3ece-486e-a798-856db1aedb67

📥 Commits

Reviewing files that changed from the base of the PR and between fa3e016 and b501f0f.

📒 Files selected for processing (2)
  • test/e2e/apisix_conf/config-docker.yaml
  • test/e2e/apisix_conf/config.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables the Apache APISIX skywalking plugin for the repo’s E2E environment by explicitly declaring the plugin list in the APISIX configs used by CI and docker-compose.

Changes:

  • Add explicit plugins arrays to the CI APISIX config so skywalking is enabled without losing existing default plugin coverage.
  • Add the same explicit plugins array to the docker-compose APISIX config for parity with CI.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
test/e2e/apisix_conf/config.yaml Adds explicit plugin allow-list including skywalking for CI APISIX container startup.
test/e2e/apisix_conf/config-docker.yaml Mirrors the explicit plugin allow-list (incl. skywalking) for local docker-compose E2E runs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +13 to +21
plugins:
- real-ip
- ai
- client-control
- proxy-control
- request-id
- zipkin
- skywalking
- ext-plugin-pre-req
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoding the entire APISIX default plugin list makes future APISIX image upgrades a bit easier to trip over (it’s not obvious this list is intended to mirror the image defaults plus skywalking). Consider adding a short inline note about where this list was sourced from / that it should be reviewed when the APISIX Docker tag changes.

Copilot uses AI. Check for mistakes.
Comment on lines +9 to +17
plugins:
- real-ip
- ai
- client-control
- proxy-control
- request-id
- zipkin
- skywalking
- ext-plugin-pre-req
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this file duplicates the full plugins list from the CI config, which is easy to forget about when updating the APISIX Docker tag. Consider adding a brief note here (or in both files) that the list is meant to track APISIX defaults plus skywalking, and should be reviewed on APISIX upgrades.

Copilot uses AI. Check for mistakes.
@guoqqqi guoqqqi merged commit efb26dd into api7:main Apr 28, 2026
10 checks passed
@guoqqqi guoqqqi deleted the test/enable-skywalking-plugin branch April 28, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants