chore: upgrade api7 and gateway to v3.9.10#280
Merged
Conversation
📝 WalkthroughWalkthroughBumped Helm chart versions and application image tags from 3.9.9 to 3.9.10 across api7 and gateway charts. Added new telemetry configuration section to api7 dashboard settings with default parameters for metrics collection. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
charts/api7/README.md (1)
100-104: Add descriptions for new telemetry values in the table.Line 100–104 currently introduce new keys with empty descriptions, which makes safe tuning harder during upgrades.
📘 Suggested README table improvement
-| dashboard_configuration.telemetry.compression_level | int | `-1` | | -| dashboard_configuration.telemetry.enable | bool | `true` | | -| dashboard_configuration.telemetry.interval | int | `15` | | -| dashboard_configuration.telemetry.max_metrics_size | int | `33554432` | | -| dashboard_configuration.telemetry.metrics_batch_size | int | `4194304` | | +| dashboard_configuration.telemetry.compression_level | int | `-1` | gzip compression level (`-1` default, `0-9` valid levels) | +| dashboard_configuration.telemetry.enable | bool | `true` | Enable telemetry reporting to control plane | +| dashboard_configuration.telemetry.interval | int | `15` | Report interval in seconds | +| dashboard_configuration.telemetry.max_metrics_size | int | `33554432` | Max telemetry payload size in bytes before truncation | +| dashboard_configuration.telemetry.metrics_batch_size | int | `4194304` | Batch size in bytes before compression |🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@charts/api7/README.md` around lines 100 - 104, The telemetry table rows for dashboard_configuration.telemetry (keys: compression_level, enable, interval, max_metrics_size, metrics_batch_size) lack descriptions; update the README table by adding concise descriptions for each key explaining purpose, accepted values/ranges, defaults and guidance for safe tuning during upgrades (e.g., compression_level: -1=no compression or 0-9 levels; enable: toggle telemetry collection; interval: seconds between reports; max_metrics_size: max payload bytes; metrics_batch_size: max bytes per send), and include any upgrade/compatibility notes or recommended safe defaults.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@charts/api7/README.md`:
- Around line 100-104: The telemetry table rows for
dashboard_configuration.telemetry (keys: compression_level, enable, interval,
max_metrics_size, metrics_batch_size) lack descriptions; update the README table
by adding concise descriptions for each key explaining purpose, accepted
values/ranges, defaults and guidance for safe tuning during upgrades (e.g.,
compression_level: -1=no compression or 0-9 levels; enable: toggle telemetry
collection; interval: seconds between reports; max_metrics_size: max payload
bytes; metrics_batch_size: max bytes per send), and include any
upgrade/compatibility notes or recommended safe defaults.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 432a60af-5d73-464c-b965-78b2c0b7d5e0
📒 Files selected for processing (6)
charts/api7/Chart.yamlcharts/api7/README.mdcharts/api7/values.yamlcharts/gateway/Chart.yamlcharts/gateway/README.mdcharts/gateway/values.yaml
nic-6443
approved these changes
Apr 22, 2026
This was referenced Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Version bumps
Structural changes
telemetrysection todashboard_configurationin api7 values.yaml (from CP helm PR — enables CP-managed telemetry config pushed to DP via heartbeat)Summary by CodeRabbit
Chores
New Features