chore: fix folder path and exception exit #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzp2010
approved these changes
Jun 27, 2022
bzp2010
reviewed
Jun 27, 2022
| # ${3} - COS path | ||
| coscli -e "${VAR_COS_ENDPOINT}" rm -r -f "cos://${2}/packages/${3}" | ||
| coscli -e "${VAR_COS_ENDPOINT}" cp -r "cos://${1}/packages/${3}" "cos://${2}/packages" | ||
| coscli -e "${VAR_COS_ENDPOINT}" rm -r -f "cos://${2}/packages/${3}" || true |
Collaborator
There was a problem hiding this comment.
Do we need to make sure it is removed successfully?
Contributor
Author
There was a problem hiding this comment.
Currently it is not needed, if the folder that needs to be deleted does not exist (e.g. there is no /packages/centos directory in VAR_COS_BUCKET_CI now) then an error will be thrown. The purpose here is to ensure that the directory to be deleted must not exist, either not originally or not after a successful deletion.
spacewander
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
success build CI:https://github.com/tzssangglass/apisix-build-tools/runs/7068733499?check_suite_focus=true
download link: https://apisix-repo-1312610933.cos.ap-nanjing.myqcloud.com/packages/centos/7/x86_64/apisix-2.13.2-0.el7.x86_64.rpm