Skip to content

Conversation

@spacewander
Copy link
Contributor

Signed-off-by: spacewander spacewanderlzx@gmail.com

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review November 4, 2022 05:53
@spacewander spacewander requested a review from soulbird November 4, 2022 05:54
@soulbird
Copy link
Contributor

soulbird commented Nov 4, 2022

If ntls is enabled, is it still possible to use normal tls handshake?

@spacewander
Copy link
Contributor Author

If ntls is enabled, is it still possible to use normal tls handshake?

Yes. The state machine in Tongsuo will check if the client uses GM or not.

@soulbird
Copy link
Contributor

soulbird commented Nov 4, 2022

If ntls is enabled, is it still possible to use normal tls handshake?

Yes. The state machine in Tongsuo will check if the client uses GM or not.

Can you add a test case ?

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
listen 1994 ssl;
server_name test.com;
ssl_certificate_by_lua_block {
local ngx_ssl = require "ngx.ssl"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reuse set_gm_cert_and_key ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way to set GM cert is too different to reuse. They only have few similarities.

@spacewander spacewander merged commit 719d638 into api7:main Nov 4, 2022
@spacewander spacewander deleted the xla branch November 4, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants