feat: support Dockerfile#188
Merged
juzhiyuan merged 1 commit intoapi7:masterfrom May 19, 2022
SkyeYoung:feat-fe-dockerfile
Merged
feat: support Dockerfile#188juzhiyuan merged 1 commit intoapi7:masterfrom SkyeYoung:feat-fe-dockerfile
juzhiyuan merged 1 commit intoapi7:masterfrom
SkyeYoung:feat-fe-dockerfile
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
starsz
reviewed
May 19, 2022
| RUN yarn build | ||
|
|
||
| # Production image, copy all the files and run next | ||
| FROM nginx:1.20-alpine AS runner |
Contributor
There was a problem hiding this comment.
Why not use node to start a server ?
Contributor
Author
There was a problem hiding this comment.
Why not use node to start a server ?
Because it is more heavy.
juzhiyuan
approved these changes
May 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@starsz @guoqqqi @juzhiyuan