Conversation
Signed-off-by: Jarvis <jarvis@api7.ai>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR adds a new LuaRocks rockspec Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR adds the LuaRocks rockspec for releasing jsonschema version 0.9.11 so the new tag can be packaged and installed via LuaRocks.
Changes:
- Added
rockspec/jsonschema-0.9.11-0.rockspecpointing to tagv0.9.11 - Declared LuaRocks dependencies (
net-url,lrexlib-pcre) and module mappings for the build
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@rockspec/jsonschema-0.9.11-0.rockspec`:
- Around line 3-6: The source table's url currently uses the insecure git://
protocol; update the url field in the source block (the "source" table and its
"url" key) to use an HTTPS-based URL for GitHub (e.g., change
"git://github.com/api7/jsonschema.git" to a secure
"git+https://github.com/api7/jsonschema.git") while keeping the existing "tag"
value intact so installs fetch via HTTPS.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9f49de28-17c8-4264-bfc5-c0e4c4600938
📒 Files selected for processing (1)
rockspec/jsonschema-0.9.11-0.rockspec
| source = { | ||
| url = "git://github.com/api7/jsonschema.git", | ||
| tag = "v0.9.11", | ||
| } |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Verify whether git protocol works for this repo/tag vs HTTPS transport.
# Expected: git:// often fails; HTTPS should resolve the tag.
git ls-remote git://github.com/api7/jsonschema.git refs/tags/v0.9.11 || true
git ls-remote https://github.com/api7/jsonschema.git refs/tags/v0.9.11Repository: api7/jsonschema
Length of output: 145
🏁 Script executed:
# Check if there's any public information about this rockspec or repository
fd -i "jsonschema" -t f | head -20
cat rockspec/jsonschema-0.9.11-0.rockspec 2>/dev/null || echo "File not found"Repository: api7/jsonschema
Length of output: 1504
🌐 Web query:
LuaRocks git protocol support HTTPS github
💡 Result:
Yes, LuaRocks supports the Git protocol over HTTPS for GitHub repositories. In rockspecs, use the git+https:// protocol prefix in the source.url field. For GitHub repos, examples: - url = "git+https://github.com/user/repo.git" - Optionally specify tag or branch: tag = "v1.0" or branch = "main" LuaRocks requires Git installed. For HTTPS, it uses LuaSocket + LuaSec, curl, or wget (autodetects). Legacy git://github.com/... URLs still work via internal handling for backward compatibility (since LuaRocks 3.8.0), but git+https:// is recommended for security and explicitness. Source: Official rockspec format docs explicitly list git+https:// as supported. GitHub issue discussions confirm usage and requirements.
Citations:
- 1: Luarocks does not properly support Github https://github.com/... URLs. luarocks/luarocks#1408
- 2: installing a dependency which is actually a git repo luarocks/luarocks#706
- 3: source.tag versus source.branch fields in rockspecs? luarocks/luarocks#409
- 4: https://github.com/luarocks/luarocks/blob/main/docs/creating_a_rock.md
- 5: https://github.com/luarocks/luarocks/blob/main/docs/rockspec_format.md
Use HTTPS for source fetch; git:// can break installs.
Line 4 uses git://, which is unreliable for GitHub-hosted sources. LuaRocks recommends git+https:// for stability and security. Switch to an HTTPS-based source URL.
Suggested fix
source = {
- url = "git://github.com/api7/jsonschema.git",
+ url = "git+https://github.com/api7/jsonschema.git",
tag = "v0.9.11",
}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@rockspec/jsonschema-0.9.11-0.rockspec` around lines 3 - 6, The source table's
url currently uses the insecure git:// protocol; update the url field in the
source block (the "source" table and its "url" key) to use an HTTPS-based URL
for GitHub (e.g., change "git://github.com/api7/jsonschema.git" to a secure
"git+https://github.com/api7/jsonschema.git") while keeping the existing "tag"
value intact so installs fetch via HTTPS.
✅ Addressed in commit ffc4702
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Jarvis jarvis@api7.ai
Summary by CodeRabbit