Skip to content

ci: add Lua lint gate with luacheck#100

Merged
membphis merged 1 commit into
mainfrom
codex/issue-98-luacheck
May 30, 2026
Merged

ci: add Lua lint gate with luacheck#100
membphis merged 1 commit into
mainfrom
codex/issue-98-luacheck

Conversation

@membphis
Copy link
Copy Markdown
Collaborator

Summary

  • Add a LuaJIT/busted-aware .luacheckrc for lua/ and tests/lua/.
  • Add make lua-lint as the local luacheck entrypoint and list it in make help.
  • Add a CI Lua lint job that installs luacheck and runs make lua-lint.
  • Clean up the small existing Lua warnings surfaced by luacheck.

Closes #98.

Test Plan

  • PATH="/tmp/qjson-luacheck-luajit/bin:$PATH" make lua-lint
  • make lint
  • PATH="/tmp/qjson-luacheck-luajit/bin:$PATH" make test LUA_CPATH='./target/release/lib?.dylib;/tmp/qjson-luacheck-luajit/lib/lua/5.1/?.so;./vendor/lua-cjson/?.so;./target/release/lib?.so;./?.so;/usr/local/openresty/lualib/?.so;/usr/local/lib/lua/5.1/?.so;/usr/local/openresty/luajit/lib/lua/5.1/?.so'
  • cargo test --release --no-default-features
  • cargo test --features test-panic --release

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 30, 2026

Warning

Review limit reached

@membphis, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 47 minutes and 51 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c5080be5-4cc1-49f0-bc85-ac23f96840e6

📥 Commits

Reviewing files that changed from the base of the PR and between 3cc1d32 and 857f9ec.

📒 Files selected for processing (6)
  • .github/workflows/ci.yml
  • .luacheckrc
  • Makefile
  • lua/qjson/table.lua
  • tests/lua/gc_spec.lua
  • tests/lua/lazy_table_spec.lua
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/issue-98-luacheck

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@membphis membphis force-pushed the codex/issue-98-luacheck branch from 43540b9 to 857f9ec Compare May 30, 2026 13:31
@membphis membphis merged commit df7f82b into main May 30, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: add Lua lint gate with luacheck

1 participant