Skip to content

test: add EAGER/LAZY mode relation coverage#142

Merged
membphis merged 1 commit into
mainfrom
codex/issue-136-mode-relations
Jun 1, 2026
Merged

test: add EAGER/LAZY mode relation coverage#142
membphis merged 1 commit into
mainfrom
codex/issue-136-mode-relations

Conversation

@membphis
Copy link
Copy Markdown
Collaborator

@membphis membphis commented Jun 1, 2026

Summary

  • Add FFI-level EAGER/LAZY mode relationship tests for acceptance parity, deferred lazy access errors, depth limits, max_depth boundaries, trailing-content behavior, and root/cursor consistency.
  • Fix skip-cache publication so malformed lazy child walks cannot leave a partially populated cache that turns later parse errors into QJSON_NOT_FOUND.
  • Document the lazy nested-container offset boundary where root path resolution has no stable inner offset but cursor-relative access can report the container opener.

Fixes #136

Test Plan

  • make lint
  • cargo test --release --test ffi_mode_relations
  • cargo test --release --no-default-features --test ffi_mode_relations
  • cargo test --release
  • cargo test --release --no-default-features
  • cargo test --features test-panic --release
  • cargo test --no-default-features
  • LuaJIT busted via LuaRocks 5.1 runner: 257 successes / 0 failures / 0 errors / 3 pending
  • Lua lint via LuaRocks 5.1 runner: 0 warnings / 0 errors

Note: local make test reached the Lua step and then failed because the default Homebrew busted wrapper targets Lua 5.5. The Lua tests were rerun successfully with the installed LuaRocks 5.1/LuaJIT runner, matching the CI ABI path.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 1, 2026

Warning

Review limit reached

@membphis, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 49 minutes and 30 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2ca7f41d-6928-4cfd-b352-32a77e247926

📥 Commits

Reviewing files that changed from the base of the PR and between 6225ce2 and 4cff06d.

📒 Files selected for processing (3)
  • src/cursor.rs
  • src/skip_cache.rs
  • tests/ffi_mode_relations.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/issue-136-mode-relations

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@membphis membphis merged commit cb573e3 into main Jun 1, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: 补充 EAGER/LAZY 模式关系测试

1 participant