Skip to content

Adding validation to don't show errors when the resource has and {id} #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
Merged

Adding validation to don't show errors when the resource has and {id} #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions src/main/java/apiaddicts/sonar/openapi/checks/parameters/OAR025LimitParameterCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,19 @@
package apiaddicts.sonar.openapi.checks.parameters;

import apiaddicts.sonar.openapi.checks.BaseCheck;
import com.google.common.collect.ImmutableSet;
import com.sonar.sslr.api.AstNode;
import com.sonar.sslr.api.AstNodeType;
import java.util.Arrays;
import java.util.HashSet;
import java.util.Set;
import java.util.stream.Collectors;

import org.apiaddicts.apitools.dosonarapi.api.v2.OpenApi2Grammar;
import org.apiaddicts.apitools.dosonarapi.api.v3.OpenApi3Grammar;
import org.apiaddicts.apitools.dosonarapi.api.v31.OpenApi31Grammar;
import org.apiaddicts.apitools.dosonarapi.sslr.yaml.grammar.JsonNode;
import org.sonar.check.Rule;
import org.sonar.check.RuleProperty;
import apiaddicts.sonar.openapi.checks.BaseCheck;

import com.google.common.collect.ImmutableSet;
import com.sonar.sslr.api.AstNode;
import com.sonar.sslr.api.AstNodeType;

import java.util.Arrays;
import java.util.HashSet;

@Rule(key = OAR025LimitParameterCheck.KEY)
public class OAR025LimitParameterCheck extends BaseCheck {
Expand Down Expand Up @@ -71,7 +68,7 @@ public void visitNode(JsonNode node) {

boolean hasParameter = hasParameterInNode(node);

if (shouldIncludePath(path) && !hasParameter) {
if (shouldIncludePath(path) && !hasParameter && !isSingleResourcePath(path)) {
addIssue(KEY, translate(MESSAGE, PARAM_NAME), node.key());
}
}
Expand Down Expand Up @@ -170,4 +167,8 @@ private JsonNode resolveReference(String refValue, JsonNode root) {

return currentNode;
}

private boolean isSingleResourcePath(String path) {
return path.matches(".*/\\{[^/]+\\}$");
}
}
Loading