This repository was archived by the owner on Nov 8, 2024. It is now read-only.
Use provided index from forEach instead of computing ourselves #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing this part of the OAS 2 code base I realised the index of an item in an array was being computed using
indexOfwhile we are already in a function which has access to the index in the arguments.In theory, this may also fix a bug where the source maps could be wrong if you had two identical invalid content types in produces or consumes. (The source maps would reference the first one). I haven't validated if such bug exists it was just speculation, it may be more likely there is a unique requirement for content-types which is validated upfront.