This repository was archived by the owner on Nov 8, 2024. It is now read-only.
Support null with other types on OpenAPI 3.1
#605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kylef
commented
Feb 23, 2021
kylef
commented
- Removes nullable on OAS 3.1 (this is breaking change in 3.1 spec)
- Supports type with array of 1 item alongside null (but no other case -- that will come)
kylef
commented
Feb 23, 2021
| // On OAS 3.0, nullable is a keyword, on OAS 3.1, null goes in type | ||
| const nullable = schema.getValue('nullable'); | ||
| if (nullable) { | ||
| if (nullable || (type.includes('null') && element.element !== 'null')) { |
Member
Author
There was a problem hiding this comment.
We want to add nullable, only if the type isn't null.
type: null causes null element, whereas type: [string, null] means string element, that this branch makes nullable.
opichals
reviewed
Feb 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.