Skip to content

Conversation

@ncoquelet
Copy link
Contributor

Hi,
When we init a new apibara project with apibara init the CLI invite us to run the command npm run install but is must be npm install.
In addition, I copied and pasted the whole command proposed by CLI without paying too much attention that I need to run install and prepare command separately, and an unexpected behaviour because of the &.
I suggest clarifying things a little by using the && operator, thus allowing you to copy/paste the entire command, chaining the install and prepare commands.
Regards

@coderabbitai
Copy link

coderabbitai bot commented Mar 6, 2025

📝 Walkthrough

Walkthrough

The changes involve restructuring console log messages in the addIndexer and initializeProject functions within the CLI package. The addIndexer function now uses a single template string for commands, while the initializeProject function simplifies the install command message by removing conditional logic. Additionally, a new JSON file has been introduced for the "apibara" package, specifying metadata for a prerelease. No alterations were made to exported or public entities.

Changes

File(s) Change Summary
packages/cli/src/create/add.ts Refactored console log message: now uses a template string for commands, defining baseCommand and tsCommand for clarity.
packages/cli/src/create/init.ts Simplified console log message for installing dependencies by removing conditional logic related to the package manager.
change/apibara-267c95ee-bca5-40de-9b0f-348952969e0c.json New JSON file created with metadata for the "apibara" package, indicating a prerelease and including author email and dependent change type.

Possibly related PRs

Suggested reviewers

  • fracek
  • jaipaljadeja

Poem

I'm a rabbit hopping through the code glade,
With messages clearer, my joy won't fade.
Commands now flow like a gentle stream,
In the world of coding, I chase my dream! 🐇✨
Celebrate the changes, let the laughter beam!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c1957a7 and 84a3e2d.

📒 Files selected for processing (1)
  • packages/cli/src/create/add.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/cli/src/create/add.ts
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: test

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@fracek
Copy link
Contributor

fracek commented Mar 7, 2025

This is a good catch, thank you! Can you add a change file with pnpm beachball change? Chose a prerelease version bump.

@ncoquelet
Copy link
Contributor Author

ncoquelet commented Mar 10, 2025

This is a good catch, thank you! Can you add a change file with pnpm beachball change? Chose a prerelease version bump.

I need to run it at the monorepo level or in le CLI package ?

@jaipaljadeja
Copy link
Member

This is a good catch, thank you! Can you add a change file with pnpm beachball change? Chose a prerelease version bump.

I need to run it at the monorepo level or in le CLI project ?

monorepo level should work.

@ncoquelet
Copy link
Contributor Author

This is a good catch, thank you! Can you add a change file with pnpm beachball change? Chose a prerelease version bump.

I need to run it at the monorepo level or in le CLI project ?

monorepo level should work.

I try both and the change dir are created at monorepo level

@ncoquelet ncoquelet force-pushed the fix/wrong-intsall-command branch from 095707b to c1957a7 Compare March 10, 2025 10:21
@ncoquelet
Copy link
Contributor Author

Ok need to fix format, I don't know why my prettier don't do it

@jaipaljadeja
Copy link
Member

Can you please fix lint errors by running pnpm lint:fix

Copy link
Member

@jaipaljadeja jaipaljadeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@jaipaljadeja jaipaljadeja merged commit 05ae45d into apibara:main Mar 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants