-
Notifications
You must be signed in to change notification settings - Fork 11
feat: handle pending blocks #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThis PR introduces new prerelease JSON configuration files for multiple packages ( Changes
Sequence Diagram(s)sequenceDiagram
participant C as Client
participant M as Middleware
participant S as Storage
participant I as Invalidation
C->>M: Send block (with finality)
alt Finality is "pending"
M->>I: Invalidate state (invalidate/invalidateState/invalidateKV)
M->>M: Update prevFinality to "pending"
else Finality is accepted
M->>S: Persist state (persistState)
M->>M: Update prevFinality
end
Possibly related PRs
Suggested reviewers
Poem
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
fracek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. It looks like we can simplify some of the logic based on the fact that state is not persisted for pending blocks.
good catch! just pushed the changes. |
adds logic to handle pending blocks in all three plugins - drizzle, mongo and sqlite.
adds a condition to not call factory function for pending blocks.
adds necessary tests for all plugins.