Skip to content

Fix issue with missing uniqueKey in evm-rpc#218

Merged
fracek merged 2 commits into
mainfrom
fra/fix-missing-unique-key
Apr 30, 2026
Merged

Fix issue with missing uniqueKey in evm-rpc#218
fracek merged 2 commits into
mainfrom
fra/fix-missing-unique-key

Conversation

@fracek
Copy link
Copy Markdown
Contributor

@fracek fracek commented Apr 30, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 63674fca-a7f1-4fcc-9cd0-be535970ea2c

📥 Commits

Reviewing files that changed from the base of the PR and between e27c315 and 0af0a9e.

📒 Files selected for processing (8)
  • change/@apibara-beaconchain-a36ce00c-02ec-4f21-a805-7a8608fd8049.json
  • change/@apibara-evm-9d1b44e3-f3b4-4629-876f-5c2cddb1ad48.json
  • change/@apibara-evm-rpc-26caf1bd-7243-4948-b098-40a3461b75ee.json
  • change/@apibara-starknet-b2fd33e6-3422-4b15-9618-e1dc2b804609.json
  • packages/beaconchain/src/proto/google/protobuf/timestamp.ts
  • packages/evm-rpc/src/stream-config.ts
  • packages/evm/src/proto/google/protobuf/timestamp.ts
  • packages/starknet/src/proto/google/protobuf/timestamp.ts

📝 Walkthrough

Walkthrough

The PR adds change manifests tracking a patch update to include uniqueKey in EVM-RPC data messages and clarifies JSDoc documentation for Timestamp fields across three packages. A functional change updates the stream configuration cursor to include block hash as a unique key alongside block number.

Changes

Cohort / File(s) Summary
Change Manifests
change/@apibara-beaconchain-*, change/@apibara-evm-*, change/@apibara-evm-rpc-*, change/@apibara-starknet-*
Four new patch-level change manifest files documenting the inclusion of uniqueKey in EVM-RPC data messages across related packages.
Timestamp Documentation
packages/beaconchain/src/proto/.../timestamp.ts, packages/evm/src/proto/.../timestamp.ts, packages/starknet/src/proto/.../timestamp.ts
JSDoc clarifications for Timestamp.seconds and Timestamp.nanos fields, specifying explicit numeric bounds (−315576000000 to 315576000000 for seconds, 0 to 999,999,999 for nanos) and clarifying semantic roles.
Stream Configuration
packages/evm-rpc/src/stream-config.ts
Updates endCursor in fetchBlockRange to include uniqueKey: header.blockHash alongside orderKey: blockNumber, ensuring unique cursor identification per block.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • jaipaljadeja

Poem

🐰 The cursor hops with hashes new,
Uniquely tied to blocks so true,
Timestamps now speak crystal clear,
From nanoseconds far and near!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess relatedness to the changeset. Add a pull request description explaining the change and its impact, such as why uniqueKey is needed in the evm-rpc cursor.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title directly addresses the main change: adding uniqueKey to evm-rpc cursor generation in fetchBlockRange.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fra/fix-missing-unique-key

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@fracek fracek merged commit a3ccf21 into main Apr 30, 2026
2 checks passed
@fracek fracek deleted the fra/fix-missing-unique-key branch April 30, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant