Use play.utils.UriEncoding.encodePathSegment to encode path segments.#122
Merged
mbryzek merged 1 commit intoapicollective:masterfrom Aug 5, 2014
fiadliel:wip/path-encode
Merged
Use play.utils.UriEncoding.encodePathSegment to encode path segments.#122mbryzek merged 1 commit intoapicollective:masterfrom fiadliel:wip/path-encode
mbryzek merged 1 commit intoapicollective:masterfrom
fiadliel:wip/path-encode
Conversation
java.net.URLEncoder.encode does not encode path parameters correctly, while it is (mostly) sufficient for query parameters. Use a Play API call which tries to do the right thing, see the API at http://www.playframework.com/documentation/2.3.x/api/scala/index.html#play.utils.UriEncoding Path segment encoding differs from encoding for other parts of a URI. For example, the "&" character is permitted in a path segment, but has special meaning in query parameters. On the other hand, the "/" character cannot appear in a path segment, as it is the path delimiter, so it must be encoded as "%2F". These are just two examples of the differences between path segment and query string encoding; there are other differences too.
Collaborator
|
+2 |
mbryzek
added a commit
that referenced
this pull request
Aug 5, 2014
Use play.utils.UriEncoding.encodePathSegment to encode path segments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
java.net.URLEncoder.encode does not encode path parameters correctly, while
it is (mostly) sufficient for query parameters. Use a Play API call which
tries to do the right thing, see the API at
http://www.playframework.com/documentation/2.3.x/api/scala/index.html#play.utils.UriEncoding$
Path segment encoding differs from encoding for other parts of a URI. For
example, the "&" character is permitted in a path segment, but has special
meaning in query parameters. On the other hand, the "/" character cannot appear
in a path segment, as it is the path delimiter, so it must be encoded as "%2F".
These are just two examples of the differences between path segment and query
string encoding; there are other differences too.