Conversation
Collaborator
mbryzek
commented
Aug 12, 2014
mbryzek
commented
- Fixes Enums as first class objects #96
- Introduce enums as first class element
Contributor
There was a problem hiding this comment.
Seems odd that name of the value is optional, since that is what the enum is.
Collaborator
Author
There was a problem hiding this comment.
InternalServiceDescription is used only for validation - making it optional here let's us return a nice validation error to the user. You will see it is NOT optional in ServiceDescription which is the base class for all the rest of apidoc
mbryzek
added a commit
that referenced
this pull request
Aug 13, 2014
Enums are now First Class. - Specified in top level at same level as models - No longer support the 'enum' option on fields (breaking change)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.