Skip to content

Import Swagger YAML files.#618

Merged
mbryzek merged 5 commits intoapicollective:masterfrom
fabiocognigni:585-swagger-yaml
Jun 3, 2017
Merged

Import Swagger YAML files.#618
mbryzek merged 5 commits intoapicollective:masterfrom
fabiocognigni:585-swagger-yaml

Conversation

@fabiocognigni
Copy link
Contributor

@fabiocognigni fabiocognigni commented May 29, 2017

The Swagger Java parser accepts both YAML and JSON files content.
This addresses #585

Notes:

  • tried https://gist.github.com/earth2marsh/264123aefc2e29551d9d but it doesn't seem a good spec (note all $ref doesn't have #/defintions/ prefix);
  • this seems to fix it but still apidoc can't import it: I can reproduce the same error with the same spec in JSON format (translated using swaggerhub) so I believe the issue doesn't depend on these changes but it's more deep in the swagger integration regardless of the swagger format - troubleshooting was taking too long so I'll probably open a new issue for this;
  • tests with YAML versions of JSON specs that were correctly imported looks fine.

The Swagger Java parser accepts both YAML and JSON files content.

This addresses apicollective#585
@mbryzek
Copy link
Collaborator

mbryzek commented May 29, 2017

lgtm

@fabiocognigni fabiocognigni mentioned this pull request Jun 2, 2017
@fabiocognigni fabiocognigni changed the title Import Swagger YAML files. --DO NOT MERGE YET Import Swagger YAML files. Jun 2, 2017
@fabiocognigni
Copy link
Contributor Author

@mbryzek this is now completed

@mbryzek
Copy link
Collaborator

mbryzek commented Jun 3, 2017

nice! merging

@mbryzek mbryzek merged commit 1861570 into apicollective:master Jun 3, 2017
@mbryzek
Copy link
Collaborator

mbryzek commented Jun 3, 2017

now live

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants