Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Conversation

@omargho
Copy link

@omargho omargho commented Jan 2, 2020

Every parser should return a truthly value in order to escape this check

apidoc-core/lib/parser.js

Lines 291 to 293 in 8c2798c

if ( ! values)
throw new ParserError('Empty parser result.',
self.filename, (blockIndex + 1), element.sourceName, element.source);

@NicolasCARPi
Copy link
Collaborator

I still don't manage to make an api disappear with the --private flag, do you?

@omargho
Copy link
Author

omargho commented Jan 2, 2020

by default without adding the argument --private the api element will disappear, it works for me

@NicolasCARPi
Copy link
Collaborator

it works for me

Well, not for me but your change lgtm.

@NicolasCARPi NicolasCARPi merged commit 28ff24f into apidoc:dev Jan 3, 2020
@gemal
Copy link
Contributor

gemal commented Feb 2, 2020

when will this fix be available in a release?
https://github.com/apidoc/apidoc-core/blob/master/lib/parsers/api_private.js

@NicolasCARPi
Copy link
Collaborator

@gemal It was an oversight/error. I've just pushed it to master and tagged 0.11.1. Now @rottmann can npm publish it. Thanks for bringing it to my attention.

@rottmann
Copy link
Member

rottmann commented Feb 4, 2020

@NicolasCARPi it is now published.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants