Skip to content

feat: Add custom GitHub Actions to a separate repository#1

Merged
fnesveda merged 3 commits into
mainfrom
feat/add-actions
May 15, 2026
Merged

feat: Add custom GitHub Actions to a separate repository#1
fnesveda merged 3 commits into
mainfrom
feat/add-actions

Conversation

@fnesveda
Copy link
Copy Markdown
Member

I was adding the usage of our custom GitHub Actions to a lot of repositories, and it felt confusing that actions live in a repository called workflows.

I've moved them to this new repository which will contain just actions, so that you can use them as it would make sense, e.g.:

  - name: Commit to a new branch
    uses: apify/actions/signed-commit@v1.0.0
    with:
      commit-message: "chore: add greeting"

I've also done some changes to simplify the setup:

  • I've rewritten the execute-workflow action to use a composite action using github-script, so that it doesn't need to be compiled (since github-script can run TypeScript files natively)
  • I've renamed the commit action to signed-commit to make it clearer why it's used just from the name

After this is merged, I will replace all the relevant usages of apify/workflows in other repositories with apify/actions and then delete the custom actions from the workflows repository.

@fnesveda fnesveda self-assigned this May 14, 2026
@janbuchar
Copy link
Copy Markdown

This caught my eye:

* I've rewritten the `execute-workflow` action to use a composite action using `github-script`, so that it doesn't need to be compiled (since `github-script` can run TypeScript files natively)

...usually, you write typescript so that it can be checked, and I highly doubt that tsc --noEmit will search yaml files for inline typescript

@fnesveda
Copy link
Copy Markdown
Member Author

fnesveda commented May 14, 2026

This caught my eye:

* I've rewritten the ``execute-workflow`` action to use a composite action using ``github-script``, so that it doesn't need to be compiled (since ``github-script`` can run TypeScript files natively)

...usually, you write typescript so that it can be checked, and I highly doubt that tsc --noEmit will search yaml files for inline typescript

It won't, but the main logic of the action is in its own .ts file, so that it can be type-checked, the yaml file of the action contains just a thin wrapper around it.

@janbuchar
Copy link
Copy Markdown

This caught my eye:

* I've rewritten the ```execute-workflow````action to use a composite action using````github-script````, so that it doesn't need to be compiled (since````github-script``` can run TypeScript files natively)

...usually, you write typescript so that it can be checked, and I highly doubt that tsc --noEmit will search yaml files for inline typescript

It won't, but the main logic of the action is in its own .ts file, so that it can be type-checked, the yaml file of the action contains just a thin wrapper around it.

I see. I guess that should work. Oh, also there is one more custom action in apify/workflows#238 - could you add it here as well?

@fnesveda
Copy link
Copy Markdown
Member Author

Oh, also there is one more custom action in apify/workflows#238 - could you add it here as well?

OK, added 👍

Copy link
Copy Markdown

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

Just one question: do we want to use main or master? 😄 AFAIK, all our repos use master except apify/workflows, which uses main 🙈.

@fnesveda
Copy link
Copy Markdown
Member Author

I think the old repos use master and most new repos use main, since main is the new default for a couple of years now 🙂 Since there is no consistency anymore, let's use main since it's the default now.

@vdusek
Copy link
Copy Markdown

vdusek commented May 15, 2026

I think the old repos use master and most new repos use main, since main is the new default for a couple of years now 🙂 Since there is no consistency anymore, let's use main since it's the default now.

Okay, just add that master is still the default branch name in git itself, default main is a GitHub thing.

@fnesveda fnesveda merged commit 09aeef7 into main May 15, 2026
3 checks passed
@fnesveda fnesveda deleted the feat/add-actions branch May 15, 2026 13:59
fnesveda pushed a commit that referenced this pull request May 15, 2026
🤖 I have created a release *beep* *boop*
---


## 1.0.0 (2026-05-15)


### Features

* Add custom GitHub Actions to a separate repository
([#1](#1))
([09aeef7](09aeef7))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants