feat: enhance MongoDB index checker with detailed sharding guidelines and common patterns#25
Merged
Merged
Conversation
… and common patterns
mtrunkat
approved these changes
May 29, 2026
mvolfik
reviewed
May 29, 2026
mvolfik
left a comment
mvolfik
left a comment
Member
There was a problem hiding this comment.
i have no idea how to review this, nothing here seems factually wrong, don't know what else is expected from a prompt review
Member
Author
I think that's enough and we will see and can modify it later. You're on review mainly to be aware of this :) |
valekjo
approved these changes
Jun 3, 2026
valekjo
left a comment
valekjo
left a comment
Member
There was a problem hiding this comment.
Looks good, some tiny suggestions, and I'm not even very sure about those :D
|
|
||
| Flag only when ALL of the following hold: | ||
| - The collection is multi-shard (per `mongo_connection.ts`). | ||
| - At least one shard-key field is *entirely absent* from the filter object — not just `undefined`, *missing*. |
Member
There was a problem hiding this comment.
Question: Isn't this already covered by the types?
Member
Author
There was a problem hiding this comment.
It is, but this is mainly to teach claude, that when there is undefined it should not report it as a missing shard key
fnesveda
pushed a commit
that referenced
this pull request
Jun 23, 2026
🤖 I have created a release *beep* *boop* --- ## [1.3.0](v1.2.0...v1.3.0) (2026-06-05) ### Features * enhance MongoDB index checker with detailed sharding guidelines and common patterns ([#25](#25)) ([ebbf103](ebbf103)) * extend MongoDB index-check prompt with six more review patterns ([#21](#21)) ([8bab229](8bab229)) * PR title check action ([#24](#24)) ([28507c2](28507c2)) * Update model version from claude-opus-4-7 to claude-opus-4-8 ([#26](#26)) ([f4bd7c9](f4bd7c9)) ### Bug Fixes * **git-cliff-release:** Improve behavior with no existing version tag ([#27](#27)) ([9d7631e](9d7631e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are false positives in evaluation of sharding rules, for example here: https://github.com/apify/apify-core/pull/28206#pullrequestreview-4372775926
This should hopefully perform better.
Note: waiting for https://github.com/apify/apify-core/pull/28238