refactor: drop severity-threshold input from mongodb-query-index-check#4
Merged
mtrunkat merged 1 commit intoMay 16, 2026
Conversation
Address PR review feedback on action.yaml line 33: collapse the strictness surface to a single `request-changes` toggle. * Drop `severity-threshold` input. * Drop the `severity_rank()` bash function and the threshold/rank comparison in the Finalize step. Finalize now just fails when `request-changes: true` and Claude reported any severity other than `none`. * Drop `$SEVERITY_THRESHOLD` from the envsubst allowlist and the prompt template. The "Decide the review event" section collapses to a single conditional on `$REQUEST_CHANGES_MODE`. * Drop the now-vestigial `$RESULT_PATH` file-exists fallback — the Validate step always seeds the file before Finalize can run. * Update README inputs table and how-it-works prose. Inputs go from 7 → 6. No behavioural change for callers using the old defaults; callers that set `severity-threshold` will need to drop it.
mtrunkat
merged commit 0f7ffe6
into
claude/mongodb-query-index-action-rmvAP
3 checks passed
There was a problem hiding this comment.
Pull request overview
This PR simplifies mongodb-query-index-check by removing the configurable severity threshold and making request-changes the single control for whether findings fail the check.
Changes:
- Removes the
severity-thresholdinput and related validation/comparison logic. - Updates the Claude prompt to request changes whenever findings exist and
request-changesis true. - Updates README/action documentation to describe the new fail-on-any-finding behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
mongodb-query-index-check/action.yaml |
Removes threshold input/env handling and changes finalization to fail on any non-none severity. |
mongodb-query-index-check/prompts/review.md |
Removes threshold prompt variables and simplifies review-event selection. |
mongodb-query-index-check/README.md |
Updates user-facing input and workflow documentation for the simplified policy. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+183
to
+184
| if [ "$INPUT_REQUEST_CHANGES" = "true" ] && [ "$max_severity" != "none" ]; then | ||
| echo "::error::MongoDB index review found '${max_severity}' issues. See the inline review comments on this PR." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address PR review feedback on action.yaml line 33: collapse the strictness surface to a single
request-changestoggle.severity-thresholdinput.severity_rank()bash function and the threshold/rank comparison in the Finalize step. Finalize now just fails whenrequest-changes: trueand Claude reported any severity other thannone.$SEVERITY_THRESHOLDfrom the envsubst allowlist and the prompt template. The "Decide the review event" section collapses to a single conditional on$REQUEST_CHANGES_MODE.$RESULT_PATHfile-exists fallback — the Validate step always seeds the file before Finalize can run.Inputs go from 7 → 6. No behavioural change for callers using the old defaults; callers that set
severity-thresholdwill need to drop it.