Explain terminal disconnects via ttyd's reconnect overlay#59
Merged
Conversation
The server-side shutdown banner couldn't catch the common stops. The Apify SDK installs no SIGTERM/SIGINT handlers (it's driven by the platform events WebSocket), so the `listenerCount(signal) > 0` guard was always false and the signal listener never attached — run timeouts, hard aborts and scale-downs showed nothing. A dying process also can't reliably flush a banner. Instead, inject a small script into ttyd's page that relabels its own reconnect overlay in the browser, where every disconnect is observable: "Connection lost — press ⏎ to reconnect", and "Actor probably finished" once a retry fails. Drop the dead signal-handler block; keep the `migrating`/ `aborting` event banners, which do arrive in advance. https://claude.ai/code/session_0127nqswxmANoa8VfkmRArmY
jancurn
changed the title
jancurn
added a commit
that referenced
this pull request
Jun 7, 2026
The client-side reconnect overlay (added in #59) now covers every stop, so the racy direct-socket banner, the migrating/aborting notices, and shutdown.ts are redundant. Delete them — the idle timeout just calls Actor.exit. Repoint the ttyd pin rationale at the overlay strings the injected client script matches. https://claude.ai/code/session_0127nqswxmANoa8VfkmRArmY Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SIGTERM/SIGINThandlers (it's driven by the platform events WebSocket), so the signal-guarded listener never attached — run timeouts, hard aborts and scale-downs showed nothing. A dying process can't reliably flush a banner either.shutdown.ts, the direct-socket writes, themigrating/aborting/idle banners); the idle timeout just callsActor.exit.