Skip to content

fix: Set correct exit code on incorect apify secrets usage#1021

Open
janbuchar wants to merge 2 commits intomasterfrom
fix-secrets-add-exit-code
Open

fix: Set correct exit code on incorect apify secrets usage#1021
janbuchar wants to merge 2 commits intomasterfrom
fix-secrets-add-exit-code

Conversation

@janbuchar
Copy link
Contributor

@janbuchar janbuchar added the t-tooling Issues with this label are in the ownership of the tooling team. label Feb 12, 2026
@janbuchar janbuchar requested a review from l2ysho February 12, 2026 15:38
@github-actions github-actions bot added this to the 134th sprint - Tooling team milestone Feb 12, 2026
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Feb 12, 2026
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for this PR instead of the copilot PR?

@janbuchar
Copy link
Contributor Author

Any reason for this PR instead of the copilot PR?

it passes CI 🤷

Copy link
Contributor

@l2ysho l2ysho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (just small nit)

showUsageString: true,
});
} catch {
// Help renderer may not be registered (e.g. in tests)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want some log.warn? cc @vladfrangu

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 Imo we can even let it bubble up

Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Copilot flops for #956 after one more prompt, lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calling apify secrets add without arguments results in exit code 0

3 participants