Open
Conversation
Replace cucumber's subprocess approach with a simpler runCli() helper that spawns the real built CLI binary. Auto-detects environment via is-ci: uses dist mode locally, npx mode in CI. - Add runCli() helper (test/e2e/__helpers__/run-cli.ts) - Add 6 help command e2e tests (test/e2e/help.test.ts) - Add test:e2e and test:e2e:local scripts - Exclude test/e2e from test:local
Migrate invalid-config and actor-run-input cucumber features to Vitest. Refactor runCli() to accept array args instead of string command parsing. - Add test-actor helper (create, cleanup, corrupt, read results) - Add basic-actor.js fixture - Add invalid-config.test.ts (1 test) - Add actor-run-input.test.ts (7 tests) - Refactor runCli(binary, args) array API — no shell quoting issues
When an exit code assertion fails, the error message now includes stderr output for easier debugging. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Migrate builds-namespace cucumber feature to Vitest. Tests auth via CLI subprocess, push to platform, and exercise builds create/info/ls. - Add builds.test.ts (8 tests, requires TEST_USER_TOKEN) - Use getApifyClientOptions for correct client config - Share build ID via beforeAll in builds info describe block
New workflow runs e2e tests after every beta publish (workflow_run), daily at 06:00 UTC (schedule), and on manual dispatch with optional version override. Temporary pull_request trigger for validation. - Auto-detects CI → npx apify-cli@beta mode - Manual dispatch supports global mode with specific versions - Repo guard prevents fork execution - Command injection protection via env var indirection - 30min timeout, concurrency control - Fix || vs ?? for empty APIFY_CLI_E2E_MODE handling Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
All 22 cucumber scenarios have been migrated to Vitest e2e tests. - Delete /features/ directory (4 feature files, 6 implementation files) - Delete cucumber.json - Delete .github/workflows/cucumber.yaml - Remove @cucumber/cucumber from devDependencies - Remove test:cucumber script - Remove features from lint paths - Update stale cucumber reference in call.test.ts
2 tasks
github-actions
bot
added
t-tooling
On a fresh clone, test/tmp is gitignored and doesn't exist, causing e2e tests to fail with ENOENT when execa tries to use it as cwd. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commands tested:
closes #1065