feat: surface approval URL when calling unapproved Actor#1111
Merged
Conversation
Contributor
Author
|
@vladfrangu I am not sure about the tests, Claude generated and heavily mocked 🤷🏻 there don't seem to be any other lib tests, so I think we could just remove them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tldr; the run Actor API returns an
approvalUrlwhen an Actor needs full account access — we were swallowing it and only printing the bare error message.Before
Run: Calling Actor apify/puppeteer-scraper (YJCnS9qogi9XxDgLB)
Error: This Actor requires full access to your account. You must approve its permissions before running it.
After
Handled in the same
catchblock asrecord-not-foundinrun-on-cloud.ts. Affectsapify call,apify actors call,apify actors start,apify task runandapify tasks run.Test plan
apify/puppeteer-scraper, approval URL surfaces correctlyfull-permission-actor-not-approvedbranch