Skip to content

chore: migrate from eslint to oxlint #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
B4nan merged 2 commits into from
May 6, 2026
Merged

chore: migrate from eslint to oxlint #1122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d515f1
chore: migrate from eslint to oxlint
B4nan May 5, 2026
ea2fcd7
Merge branch 'master' into chore/migrate-to-oxlint
B4nan May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 0 additions & 116 deletions eslint.config.mjs
View file
Open in desktop

This file was deleted.

41 changes: 41 additions & 0 deletions oxlint.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
import { defineConfig } from '@apify/oxlint-config';

export default defineConfig({
ignorePatterns: ['**/dist', 'node_modules', 'coverage', 'website', '**/*.d.ts', 'test/tmp/**/*'],
rules: {
'no-console': 'off',
'no-param-reassign': 'off',
'typescript/no-explicit-any': 'off',
'typescript/consistent-type-definitions': ['error', 'interface'],
'typescript/consistent-type-imports': ['error', { disallowTypeAnnotations: false }],
'typescript/no-unused-vars': [
'error',
{ argsIgnorePattern: '^_', varsIgnorePattern: '^_', ignoreRestSiblings: true },
],
'import/no-default-export': 'off',
'typescript/consistent-return': 'off',
'consistent-return': 'off',
},
overrides: [
{
files: ['test/**'],
rules: {
'no-console': 'off',
'typescript/ban-ts-comment': 'off',
'typescript/no-empty-function': 'off',
'typescript/no-unused-vars': 'off',
// Tests use the `try { await ... } catch (err) { expect(err)... }` pattern.
// Migrating to `await expect(...).rejects.toX(...)` is out of scope for the
// lint migration — follow-up to enable.
'jest/no-conditional-expect': 'off',
'vitest/no-conditional-expect': 'off',
// A handful of helper-based tests have no direct `expect` (assertions live
// in the helper). Same follow-up to clean up.
'jest/expect-expect': 'off',
'vitest/expect-expect': 'off',
'jest/no-standalone-expect': 'off',
'vitest/no-standalone-expect': 'off',
},
},
],
});
18 changes: 7 additions & 11 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"test:e2e:local": "vitest run --testNamePattern \"^(?=.*\\[e2e\\])(?!.*\\[api\\]).*$\" --exclude ./test/api",
"test:api": "vitest run --testNamePattern \"^(?=.*\\[api\\])(?!.*\\[e2e\\]).*$\" --exclude ./test/e2e",
"test:python": "vitest run --testNamePattern \"\\[python\\]\"",
"lint": "eslint",
"lint:fix": "eslint --fix",
"lint": "oxlint --type-aware",
"lint:fix": "oxlint --type-aware --fix",
"format": "biome format . && prettier --check \"**/*.{md,yml,yaml}\"",
"format:fix": "biome format --write . && prettier --write \"**/*.{md,yml,yaml}\"",
"clean": "rimraf dist",
Expand Down Expand Up @@ -119,8 +119,8 @@
"wrap-ansi": "^10.0.0"
},
"devDependencies": {
"@apify/eslint-config": "^1.1.0",
"@apify/tsconfig": "^0.1.1",
"@apify/oxlint-config": "^0.2.5",
"@apify/tsconfig": "^0.1.2",
"@biomejs/biome": "^2.4.10",
"@crawlee/types": "^3.16.0",
"@types/adm-zip": "^0.5.8",
Expand All @@ -137,19 +137,15 @@
"@types/which": "^3.0.4",
"apify": "^3.7.0",
"cross-env": "^10.1.0",
"eslint": "^9.39.4",
"eslint-config-prettier": "^10.1.8",
"eslint-plugin-react": "^7.37.5",
"eslint-plugin-react-hooks": "^7.0.1",
"globals": "^16.2.0",
"husky": "^9.1.7",
"lint-staged": "^16.4.0",
"mock-stdin": "^1.0.0",
"oxlint": "1.62.0",
"oxlint-tsgolint": "0.22.0",
"prettier": "^3.8.1",
"tsdown": "^0.21.9",
"tsx": "^4.21.0",
"typescript": "^6.0.2",
"typescript-eslint": "^8.58.0",
"vitest": "^4.1.2"
},
"volta": {
Expand All @@ -173,7 +169,7 @@
},
"lint-staged": {
"*": "biome format --write --no-errors-on-unmatched",
"*.{mjs,js,ts,mts,jsx,tsx}": "eslint --fix",
"*.{mjs,js,ts,mts,jsx,tsx}": "oxlint --type-aware --fix",
"*.md": "prettier --write"
}
}
Loading
Loading