feat: enrich cli_command_push telemetry with actorId and wasCreated#1152
Merged
Conversation
Adds `push.actorId` and `push.wasCreated` to the unified cli_command telemetry payload so we can dedupe pushes per Actor in Snowflake and attribute new-Actor creation through the CLI vs. Console surfaces. Closes #1151 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vladfrangu
approved these changes
May 26, 2026
Drop the `as unknown as { ... }` casts in favor of bracket-notation
access to the protected `telemetryData` property, matching the
codebase's existing pattern (e.g. `instance['_buildParseArgsOption']`).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
t-dx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
push.actorIdandpush.wasCreatedto the unifiedcli_commandtelemetry payload so eachcli_command_pushevent carries the Actor ID being pushed and whether the push created a new Actor vs. updated an existing one.push_actor_id/push_was_createdcolumns in Snowflake (mirroring the existingcreate.*pattern), unlocking per-surface attribution and dedup'd new-Actor counts.Closes #1151