Skip to content

chore: stop publishing broken declaration and source maps#925

Merged
B4nan merged 1 commit into
masterfrom
chore/no-broken-declaration-maps
May 29, 2026
Merged

chore: stop publishing broken declaration and source maps#925
B4nan merged 1 commit into
masterfrom
chore/no-broken-declaration-maps

Conversation

@B4nan
Copy link
Copy Markdown
Member

@B4nan B4nan commented May 29, 2026

The published tarball excludes src but ships .d.ts.map/.js.map that reference ../src/*.ts, so the maps never resolve — editors fall back to the compiled .d.ts/.js instead of the original source. Disabling declarationMap/sourceMap stops emitting these dead maps and shrinks the tarball. The rsbuild browser bundle sourcemap (which embeds its own sources) is unaffected.

🤖 Generated with Claude Code

The published tarball excludes `src` but ships `.d.ts.map`/`.js.map`
that reference `../src/*.ts`, so the maps never resolve and editors
fall back to the compiled output. Disable `declarationMap`/`sourceMap`
so these dead maps are no longer emitted. The browser bundle sourcemap
(which embeds its sources) is unaffected.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions github-actions Bot added this to the 141st sprint - Tooling team milestone May 29, 2026
@github-actions github-actions Bot added the t-tooling Issues with this label are in the ownership of the tooling team. label May 29, 2026
@B4nan B4nan added the adhoc Ad-hoc unplanned task added during the sprint. label May 29, 2026
@B4nan B4nan requested a review from barjin May 29, 2026 09:14
Copy link
Copy Markdown
Member

@barjin barjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the branch doesn't contain the changes from #919, so the failing checks are probably expected.

The changes in this branch look alright to me. Thanks @B4nan !

@B4nan B4nan merged commit 931be1f into master May 29, 2026
16 of 20 checks passed
@B4nan B4nan deleted the chore/no-broken-declaration-maps branch May 29, 2026 09:32
@B4nan
Copy link
Copy Markdown
Member Author

B4nan commented May 29, 2026

Yeah, the CI is unrelated, I guess me enabling renovate on 10 of our repos made quite a huge hit to both pw and pup servers :D I hope things will stabilize once I merge/close all those PRs, also added cache for pw browsers (but we need to update to 1.60 anyway).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants