Skip to content

feat: Add signature arguments for dataset and kvs methods #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2025
Merged

feat: Add signature arguments for dataset and kvs methods #530

merged 1 commit into from
Nov 7, 2025

Conversation

@Pijukatel
Copy link
Contributor

@Pijukatel Pijukatel commented Nov 6, 2025 •
edited
Loading

Description

Add signature argument to:

  • DatasetClient(Async).list_items
  • DatasetClient(Async).iterate_items
  • DatasetClient(Async).get_items_as_bytes
  • DatasetClient(Async).stream_items
  • DatasetClient(Async).list_keys
  • DatasetClient(Async).get_record
  • DatasetClient(Async).get_record_as_bytes
  • DatasetClient(Async).stream_record

Added tests that point to pre-created storage of specific test user.

Issues

Closes: #517

@github-actions github-actions bot added this to the 127th sprint - Tooling team milestone Nov 6, 2025
@github-actions github-actions bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels Nov 6, 2025
@Pijukatel Pijukatel requested review from barjin and vdusek November 6, 2025 14:53
@Pijukatel Pijukatel marked this pull request as ready for review November 6, 2025 14:53
vdusek
vdusek approved these changes Nov 6, 2025
View reviewed changes
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Pijukatel Pijukatel merged commit 10d1e45 into master Nov 7, 2025
30 of 31 checks passed
@Pijukatel Pijukatel deleted the add-signature-arguments branch November 7, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdusek vdusek vdusek approved these changes

@barjin barjin Awaiting requested review from barjin

Assignees

@Pijukatel Pijukatel

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Milestone

127th sprint - Tooling team

Development

Successfully merging this pull request may close these issues.

Dataset / KVS methods do not accept signature as a param

3 participants

@Pijukatel @vdusek