chore: Migrate to ty type checker
#562
Conversation
vdusek
added
adhoc
github-actions
bot
added
the
tested
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #562 +/- ##
==========================================
+ Coverage 75.98% 76.01% +0.02%
==========================================
Files 42 42
Lines 2465 2468 +3
==========================================
+ Hits 1873 1876 +3
Misses 592 592
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mantisus
left a comment
Mantisus
left a comment
There was a problem hiding this comment.
It looks promising. But I'm a little confused that we're moving to the first beta release. 🙂
|
@Mantisus Check out the release blogpost:
I tested it a few weeks ago already, and it seems to work well. I also tried the integration with VS Code and Zed, and they are also good. With the newly generated typed clients (PR #554), there will be quite a bit of refactoring ahead, mostly around the typing system. I'd prefer to do this using |
| stats = Statistics() | ||
| with pytest.raises(TypeError): | ||
| stats.add_rate_limit_error('1') # type: ignore[arg-type] | ||
| stats.add_rate_limit_error('1') # ty: ignore[invalid-argument-type] |
There was a problem hiding this comment.
Is there any sensible way we could keep both directives so that mypy still works?
There was a problem hiding this comment.
AFAIK, the only way would be to use general type: ignore - ignoring all type issues for the line. I would rather not do that.
No description provided.