Skip to content

fix: remove erroneous async keyword from sync ActorClient.default_build#620

Merged
vdusek merged 1 commit intomasterfrom
fix/sync-actor-default-build-async-keyword
Feb 17, 2026
Merged

fix: remove erroneous async keyword from sync ActorClient.default_build#620
vdusek merged 1 commit intomasterfrom
fix/sync-actor-default-build-async-keyword

Conversation

@vdusek
Copy link
Contributor

@vdusek vdusek commented Feb 17, 2026

Summary

  • ActorClient.default_build (the sync variant) was incorrectly declared as async def — a copy-paste error from the async variant
  • Calling it returned a coroutine object instead of a BuildClient, making it unusable without await (which makes no sense on the sync client)
  • Removed the async keyword so it behaves as a regular synchronous method

Test plan

  • Verify existing unit tests pass
  • Verify ActorClient(...).default_build() returns a BuildClient directly (not a coroutine)

🤖 Generated with Claude Code

The sync ActorClient.default_build was incorrectly declared as `async def`,
causing it to return a coroutine object instead of a BuildClient. This was
a copy-paste error from the async variant.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vdusek vdusek added bug Something isn't working. adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Feb 17, 2026
@vdusek vdusek self-assigned this Feb 17, 2026
@github-actions github-actions bot added this to the 134th sprint - Tooling team milestone Feb 17, 2026
@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.02%. Comparing base (e7ee8b3) to head (e23c75f).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #620   +/-   ##
=======================================
  Coverage   76.02%   76.02%           
=======================================
  Files          42       42           
  Lines        2482     2482           
=======================================
  Hits         1887     1887           
  Misses        595      595           
Flag Coverage Δ
integration 68.77% <100.00%> (ø)
unit 64.66% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek vdusek merged commit b2b1103 into master Feb 17, 2026
30 of 31 checks passed
@vdusek vdusek deleted the fix/sync-actor-default-build-async-keyword branch February 17, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments