Skip to content

ci: Fix commit and push in regenerate models workflow#702

Merged
vdusek merged 3 commits intomasterfrom
fix/regenerate-models-workflow-commit-push
Apr 7, 2026
Merged

ci: Fix commit and push in regenerate models workflow#702
vdusek merged 3 commits intomasterfrom
fix/regenerate-models-workflow-commit-push

Conversation

@vdusek
Copy link
Copy Markdown
Contributor

@vdusek vdusek commented Apr 7, 2026

Summary

Fixes two bugs in the manual_regenerate_models workflow that caused the manual run to fail:

  • Pre-commit hook blocked commit: git commit triggered the type-check hook, which failed because regenerated models removed symbols (ScheduleCreateActions, TaskOptions) still imported by client code. Added commit: --no-verify to bypass hooks — the resulting PR will get proper CI checks anyway.
    • pre commit failures should be addressed manually
  • Push failed for new branch: push: --force ran git push --force without setting upstream tracking. Changed to push: -u origin $BRANCH --force so the new branch is correctly pushed.

🤖 Generated with Claude Code

The pre-commit hook (type-check) blocked the commit because regenerated
models can remove symbols still used by client code, and the push failed
because the new branch had no upstream tracking set.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Apr 7, 2026
@vdusek vdusek self-assigned this Apr 7, 2026
@github-actions github-actions bot added this to the 138th sprint - Tooling team milestone Apr 7, 2026
@vdusek vdusek changed the title fix(ci): fix commit and push in regenerate models workflow ci: Fix commit and push in regenerate models workflow Apr 7, 2026
@vdusek vdusek requested a review from janbuchar April 7, 2026 10:44
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.96%. Comparing base (a6a6fde) to head (149eacd).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #702      +/-   ##
==========================================
- Coverage   94.98%   94.96%   -0.03%     
==========================================
  Files          45       45              
  Lines        4405     4405              
==========================================
- Hits         4184     4183       -1     
- Misses        221      222       +1     
Flag Coverage Δ
integration 94.96% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek vdusek merged commit ad53091 into master Apr 7, 2026
26 checks passed
@vdusek vdusek deleted the fix/regenerate-models-workflow-commit-push branch April 7, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants